add cyclonedds to the list of rmw using graph info topics#231
add cyclonedds to the list of rmw using graph info topics#231mikaelarguedas merged 1 commit intomasterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 23 23
Lines 609 609
Branches 53 53
=======================================
Hits 468 468
Misses 121 121
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This fixed the failures at ros2/system_tests#408 (comment) Marking this as ready for review |
kyrofa
left a comment
kyrofa
left a comment
There was a problem hiding this comment.
Awesome, thanks @mikaelarguedas!
|
may need to be backported to foxy depending on ros2/ros2#999 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-08-20/16063/1 |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
5 participants
To test if it fixes the issue of CI failing with cyclone and security from ros2/system_tests#408
Necessary since ros2/rmw_cyclonedds#145 particularily this bit https://github.com/ros2/rmw_cyclonedds/blob/3bfe094b60c1a3116b1f2c09c845a745fd240987/rmw_cyclonedds_cpp/src/rmw_node.cpp#L1026-L1035